Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump KV dep #7005

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Bump KV dep #7005

merged 1 commit into from
Jun 27, 2019

Conversation

mgaffney
Copy link
Member

@mgaffney mgaffney commented Jun 27, 2019 •
edited
Loading

I ran the following commands:

  • go get github.com/hashicorp/vault-plugin-secrets-kv@master
  • go mod vendor
  • go mod tidy

@jefferai
Copy link
Member

You should actually tidy before vendor. Otherwise it will vendor things tidy then removes!

@jefferai
Copy link
Member

(In this case it's fine, just a general workflow comment)

@mgaffney
Copy link
Member Author

I actually ran tidy before vendor. I just got the order wrong in the comment.

@mgaffney mgaffney merged commit 0a58f30 into master Jun 27, 2019
@mgaffney mgaffney deleted the mgaffney/bump-kv-dep branch June 27, 2019 16:47
@mgaffney mgaffney added this to the 1.2 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

@kalafut kalafut kalafut approved these changes

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mgaffney @jefferai @kalafut @tyrannosaurus-becks