TLS for Raft Join #6932
Merged
TLS for Raft Join #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
force-pushed
the
raft-cli
branch
2 times, most recently
from
e51c8bf to
5d4c931
Compare
vishalnayak
force-pushed
the
raft-join-tls
branch
2 times, most recently
from
765a2f3 to
2557ea2
Compare
jefferai
previously approved these changes
Jun 21, 2019
vishalnayak
force-pushed
the
raft-join-tls
branch
from
787757b to
b0cd36d
Compare
jefferai
approved these changes
Jun 21, 2019
jefferai
reviewed
Jun 21, 2019
| switch { | ||
| case req.LeaderCACert != "" && req.LeaderClientCert != "" && req.LeaderClientKey != "": | ||
| // Create TLS Config | ||
| pool := x509.NewCertPool() |
There was a problem hiding this comment.
I approved this but if you can move this section to sdk/helper/tlsutil we can reuse it elsewhere pretty quickly...
There was a problem hiding this comment.
I'll do this in a separate PR.
catsby
added a commit
that referenced
this pull request
Jun 24, 2019
* master: (47 commits) Add the ability to use a dev Consul node for dev storage (#6965) Update CHANGELOG.md Correct API docs examples (#6963) Fix test changelog++ Allow turning on client auth in test clusters (#6958) Update vendoring Update SDK version Make CA certificate optional in ClientTLSConfig Update vendor Combined Database backend: remove create/delete support (#6951) Bump sdk Move tls config creation to tlsutil (#6956) Update JWT tips (#6955) raft join tls (#6932) changelog++ UI - add kmip engine (#6936) Pass context to Cassandra queries (#6954) Minor clean up JWT provider docs (#6952) update azure instructions (#6858) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.