Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use fit-content, ff doesn't love it #6763

Merged
merged 1 commit into from
May 20, 2019
Merged

don't use fit-content, ff doesn't love it #6763

merged 1 commit into from
May 20, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented May 20, 2019

When building the production version of the app, auto-prefixer adds some vendor prefixes for FF and content-fit. This caused the new Icon SVGs to all be sized by their viewBox, breaking the layout. And it turns out that everything looks fine without this CSS declaration, so we just remove it.

Before:
image

After:
Screen Shot 2019-05-20 at 3 51 37 PM

@meirish meirish requested review from a team May 20, 2019 20:52
@meirish
Copy link
Contributor Author

meirish commented May 20, 2019

Thanks @kalafut for spotting this! 🏆 🙌 🦊 👀

@andaley andaley self-assigned this May 20, 2019
@meirish meirish merged commit 82cedbb into master May 20, 2019
@meirish meirish deleted the ui-ff-icons branch May 20, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants