Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format errors from auth-jwt plugin like other authentication errors #6553

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Apr 9, 2019

When the OIDC flow errors, what the UI displayed wasn't particularly helpful - this PR changes it so that errors from the auth-jwt component get passed through the same path as errors in the auth-form components instead of directly setting auth-form's error property.

Before:
Screen Shot 2019-04-09 at 8 22 41 AM

After
Screen Shot 2019-04-09 at 8 08 10 AM

@meirish meirish requested review from a team April 9, 2019 13:26
@meirish meirish added this to the 1.1.1 milestone Apr 9, 2019
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Is there an instance where we wouldn't want to format the error this way?

@meirish
Copy link
Contributor Author

meirish commented Apr 9, 2019

@madalynrose The default is to preface it with Authentication failed: and then join the errors. I think since we're setting errorMessage in the message-error component, we'll always want the error to be a string (which is what the handleError method does.

@meirish meirish merged commit 670f43e into master Apr 9, 2019
@meirish meirish deleted the ui-oidc-error branch April 9, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants