-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token identity support #6267
Token identity support #6267
Conversation
45f3fc4
to
06a30ab
Compare
5879275
to
7575a5a
Compare
464ecd5
to
0856c6b
Compare
0856c6b
to
17cc14a
Compare
17cc14a
to
82d2abf
Compare
b759a8d
to
8726f53
Compare
I think docs might also need to be updated here. |
I think this part needs to be updated too. |
Also the sample responses in the docs. |
8726f53
to
be14a2c
Compare
@tyrannosaurus-becks Thanks for the review. I've updated the PR.
I don't really understand why the sample responses should be updated? Cheers, |
@michelvocks I was thinking the read role doc might need to be updated. Mainly because I thought, what if someone were building a client in another language against these API endpoints, maybe they would wonder what an |
be14a2c
to
42717af
Compare
@tyrannosaurus-becks Thanks for the clarification. That makes sense. I've added a few more samples. Would be great if you could have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Can you also add a description to this PR? It would be good to talk about what the use-case is here in case we ever want to reference it in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things, looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that!
a7b05ae
…ly created when it has been specified in allowed_entity_aliases list
9e9ef84
a7b05ae
to
9e9ef84
Compare
With the support of ACL Templating, which allows users to dynamically build paths for the ACL system, it is requested to support the identity system for the token backend. If, for example, tokens created via a token role should have access to a dynamic path where a key/value secret is stored, the entity metadata could be used to dynamically form the related ACL policy.
One example use-case is Nomad’s integration with Vault. Nomad can automatically create Vault tokens with predefined policies which can be a subset of the originally provided policies. However, to use the ACL templating engine to dynamically build the policies paths, it is required that the entity attached to a newly created token can be dynamically modified.
This PR allows the modification of the entity alias of a token during token creation via a token role. Additionally, the entity alias modification is scoped by a predefined list of allowed entity aliases attached to the token role.