Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grab go files from openapi-models #6204

Merged
merged 17 commits into from
Feb 14, 2019
Merged

grab go files from openapi-models #6204

merged 17 commits into from
Feb 14, 2019

Conversation

madalynrose
Copy link
Contributor

Just the Go files from #6129

@madalynrose madalynrose requested a review from kalafut February 11, 2019 17:28
@kalafut
Copy link
Contributor

kalafut commented Feb 11, 2019

Should this PR be a merge into 1.1-beta instead? I'm not totally sure...

@madalynrose madalynrose changed the base branch from master to 1.1-beta February 12, 2019 20:31
@madalynrose
Copy link
Contributor Author

@kalafut how's this looking? all updated!

kalafut
kalafut approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments otherwise LGTM!

@madalynrose madalynrose merged commit d8e9adc into 1.1-beta Feb 14, 2019
@madalynrose madalynrose deleted the opeapi-go-paths branch February 14, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoffman chrishoffman chrishoffman left review comments

@kalafut kalafut kalafut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@madalynrose @kalafut @chrishoffman @jefferai @briankassouf @vishalnayak