Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix physical/postgresql to return the full entry key #6044

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Fix physical/postgresql to return the full entry key #6044

merged 1 commit into from
Jan 15, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Jan 15, 2019

Fixes #6041

@kalafut kalafut requested a review from briankassouf January 15, 2019 18:58
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kalafut kalafut mentioned this pull request Jan 15, 2019
Closed
@briankassouf
Copy link
Contributor

@kalafut could you verify this doesn't break backwards compat with kv-v2? Since that encrypts the key?

@kalafut
Copy link
Contributor Author

kalafut commented Jan 15, 2019

@briankassouf I reviewed all calls to Get() by the KV backend and there was never any use of the Key member, so I think we're good.

@kalafut kalafut merged commit 25ac2ad into master Jan 15, 2019
@kalafut kalafut deleted the pg-physical-fix branch January 15, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalafut @hashicorp-cla @briankassouf