Mount tune options #5809
Merged
Mount tune options #5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
commented
Nov 16, 2018
| // Reload the backend to kick off the upgrade process. | ||
| // Reload the backend to kick off the upgrade process. It should only apply to KV backend so we | ||
| // trigger based on the version logic above. | ||
| if kvUpgraded { |
There was a problem hiding this comment.
@briankassouf can you confirm that the comment/logic is true? If false, I can remove the kvUpgraded check and always run reloadBackendCommon whenever options gets updated.
kalafut
reviewed
Nov 16, 2018
briankassouf
approved these changes
Nov 19, 2018
jefferai
pushed a commit
that referenced
this pull request
Dec 14, 2018
* Refactor mount tune to support upsert options values and unset options. * Do not allow unsetting options map * add secret tune version regression test * Only accept valid options version * s/meVersion/optVersion/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following logic applies to
optionswith this PR:options["foo"] = ""), with the exception ofversionCloses #5788
Fixes #5237