Update docs to match running builtins as plugins #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalafut
reviewed
Nov 9, 2018
| @@ -108,8 +103,7 @@ This endpoint enables a new secrets engine at the given path. | |||
| These control the default and maximum lease time-to-live, force | |||
| disabling backend caching, and option plugin name for plugin backends | |||
There was a problem hiding this comment.
Remove reference to plugin name & backends.
There was a problem hiding this comment.
Good catch!
kalafut
reviewed
Nov 9, 2018
| remove plugins in Vault's catalog. Plugins must be registered before use, and | ||
| once registered backends can use the plugin by querying the catalog. | ||
|
|
||
| ## List Plugins | ||
| ## Read Plugins |
There was a problem hiding this comment.
Even though the Method has changed to GET, I think "List" is still the right word for the heading, and is consistent with following sentence.
There was a problem hiding this comment.
Good point! Also, revisiting this made me realize I'd not included the new three LIST endpoints for plugins by type, so I'm adding those.
kalafut
reviewed
Nov 9, 2018
kalafut
reviewed
Nov 9, 2018
kalafut
previously approved these changes
Nov 9, 2018
Co-Authored-By: tyrannosaurus-becks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates docs to match the changes introduced in #5536 to run all builtins as plugins.