Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style ui not bundled page #5665

Merged
merged 1 commit into from
Nov 2, 2018
Merged

style ui not bundled page #5665

merged 1 commit into from
Nov 2, 2018

Conversation

andaley
Copy link
Contributor

@andaley andaley commented Nov 1, 2018 •
edited
Loading

Apply styles to the "UI Not Bundled" page.
screen shot 2018-11-01 at 3 56 49 pm

The styles should be similar to the "Application Errors Page" shown below:
image 1

@andaley andaley requested review from a team November 1, 2018 23:00
@andaley andaley force-pushed the ui/style-ui-not-bundled-page branch from 5509175 to 1113130 Compare November 2, 2018 17:14
joshuaogle
joshuaogle previously approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@joshuaogle joshuaogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small code style comment, but looks good! I'm sure this was fun 😬

http/handler.go Outdated Show resolved Hide resolved
@andaley andaley force-pushed the ui/style-ui-not-bundled-page branch from 1113130 to 6aee9b3 Compare November 2, 2018 20:29
@andaley andaley merged commit 18080f6 into master Nov 2, 2018
@andaley andaley deleted the ui/style-ui-not-bundled-page branch November 2, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaogle joshuaogle joshuaogle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andaley @joshuaogle