UI - new token renew banner #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
reviewed
Nov 1, 2018
| @@ -56,7 +56,7 @@ module('Integration | Component | license info', function(hooks) { | |||
| await render( | |||
| hbs`<LicenseInfo @licenseId={{this.licenseId}} @expirationTime={{this.expirationTime}} @startTime={{this.startTime}} @features={{this.features}}/>` | |||
| ); | |||
| assert.equal(component.featureRows.length, 12, 'it renders 12 features'); | |||
| assert.equal(component.featureRows.length, 9, 'it renders 9 features'); | |||
There was a problem hiding this comment.
we could just have this call the helper and make sure it's the same length as the list the helper has?
There was a problem hiding this comment.
Oh yeah that's nicer
meirish
force-pushed
the
ui-new-token-renew-banner
branch
2 times, most recently
from
58d3984 to
c26e4fd
Compare
meirish
force-pushed
the
ui-new-token-renew-banner
branch
from
1084900 to
6b851fa
Compare
joshuaogle
suggested changes
Nov 2, 2018
joshuaogle
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the UI notifies you about suspended auto-renewal of your Vault token.
Previously there was a big yellow banner telling you that you needed to click a button to resume auto-renewal if you were idle for a period of time in the UI. Now, we've shuffled that alert into the user menu, so all that you see is a yellow dot on the user icon, and if you navigate anywhere that triggers an api call, we'll resume renewal for you automatically.
Just the beacon:
With the user menu open:
Note: styling on this will change as all of the alert styling is currently being worked on.
Fixes #4840