change capabilities logic for sudo prefixes #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties prefix logic
meirish
reviewed
Oct 30, 2018
| }) | ||
| ); | ||
| assert.ok(model.get('canRead')); | ||
| assert.notOk(model.get('canCreate'), 'sudo requires the capability to be set as well'); |
There was a problem hiding this comment.
I think this doesn't have to do with sudo, just that create wasn't in the capabilities list.
There was a problem hiding this comment.
it's in every test so I just left it
meirish
reviewed
Oct 30, 2018
| assert.ok(model.get('canUpdate'), 'should not require sudo if it has update'); | ||
| assert.notOk(model.get('canDelete')); | ||
| assert.notOk(model.get('canList')); | ||
| }); |
There was a problem hiding this comment.
Can we add another test for the paths in the SUDO_PREFIX arg too to make sure they are requiring sudo?
So for path: 'sys/leases/revoke-prefix/aws' with capabilities "update", canUpdate should be false, but with "update", "sudo", canUpdate should be true.
There was a problem hiding this comment.
I added a couple. Do they look right?
meirish
previously approved these changes
Oct 30, 2018
added 2 commits
October 30, 2018 15:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specifically for sys/leases/revoke with update capability