-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive identity names #5404
Merged
+423
−32
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
750917d
case insensitive identity names
vishalnayak c07c2b5
Merge branch 'master-oss' into case-insensitive-identity-names
vishalnayak 2412e4f
TestIdentityStore_GroupHierarchyCases
vishalnayak 242a2a3
Merge branch 'master-oss' into case-insensitive-identity-names
vishalnayak 328119f
address review feedback
vishalnayak f7f34c0
Use errwrap.Contains instead of errwrap.ContainsType
vishalnayak 2e7f6ce
Warn about duplicate names all the time to help fix them
vishalnayak 50d3598
Address review feedback
vishalnayak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
address review feedback
- Loading branch information
commit 328119fc1a2c568d963825ce2d8c2f67d9754ec0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think ContainsType does what you think it does here, which makes me wonder if this works properly. ContainsType is supposed to be used to validate a typed error, which means this will likely match against any error generated via
errors.New
. You probably want.Contains()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. This is a nice observation. Fixed. But the code was working properly because the code expecting a
true
and ContainsType (as you said) was returningtrue
. There wasn't a different error there to catch. I tested it by overwriting theerr
returned fromloadFunc
and verified that its getting caught properly now.