Allow most parts of Vault's logging to have its level changed on-the-fly #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
jit-logging-level
branch
from
bc67f2d to
b0a4878
Compare
kalafut
reviewed
Sep 5, 2018
command/server.go
Outdated
| @@ -152,7 +152,7 @@ func (c *ServerCommand) Flags() *FlagSets { | |||
| f.StringVar(&StringVar{ | |||
| Name: "log-level", | |||
| Target: &c.flagLogLevel, | |||
| Default: "info", | |||
| Default: "(not set)", | |||
There was a problem hiding this comment.
I'd recommend defining a constant for this since it is coupled to logic below further down.
There was a problem hiding this comment.
I knew someone was going to point that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this out and it works well. There's currently no way to clean loggers from the slice but that should be fine, at least for now. This doesn't currently affect plugins since we don't have a call that can go across the logical/plugin interface.