Switch to a forked copy of pkcs7 to fix aws pkcs7 verification error #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please release :) |
|
@jefferai is it likely to be a quick release with this fix? seem like a pretty big regression, sufficiently big to yield a new patch release :) |
|
The chances will go way up if you can independently verify this fixes the problem and report back, as I've not had a chance to run testing suites. |
|
@joelthompson in case you're bored and have a good test setup at the ready :-) |
jefferai
added a commit
that referenced
this pull request
Feb 23, 2018
|
For future reference, I tested both this fork of the pcks7 library as well as the updated upstream one, built using go1.10, and verified that both of them passed the test suites. |
|
Thanks @joelthompson ! |
chrishoffman
pushed a commit
that referenced
this pull request
Feb 23, 2018
* oss/master: (35 commits) helper/gpgkeys: fix for vault 1.10 (#4038) Move local cluster parameters to atomic values to fix some potential data races (#4036) Port some replicated cluster changes from ent (#4037) Add core object to policy store for some ent uses changelog++ Configurable Consul Service Address (#3971) Fix certutil test Fixed a broken link (#4032) Update comment to replication consts Add a helpful comment to replication consts changelog++ auth/aws: Add functional test for detached RSA signature (#4031) Change Go min version check changelog++ Revert Go dep to 1.9 *Partially* revert "Remove now-unneeded PKCS8 code and update certutil tests for Go 1.10" Revert "Remove unneeded looping since Go 1.10 cover it already (#4010)" Bump pkcs7 library version to fix #4024 Revert "Switch to a forked copy of pkcs7 to fix aws pkcs7 verification error (#4024)" changelog++ ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4014