plugins/gRPC: fix issues with reserved keywords in response data #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
previously approved these changes
Jan 31, 2018
jefferai
reviewed
Feb 1, 2018
| @@ -200,8 +201,14 @@ func respondRaw(w http.ResponseWriter, r *http.Request, resp *logical.Response) | |||
| retErr(w, "no status code given") | |||
| return | |||
| } | |||
| status, ok := statusRaw.(int) | |||
| if !ok { | |||
|
|
|||
There was a problem hiding this comment.
For safety, you should add a json.Number check in here too, in case something has already serialized the data for some reason. It would be handled transparently by the JSON encoder for the response but would trip this here.
|
One comment, other than that LGTM! |
|
LGTM means Lists Good to Me? Because, list works for my plugin now! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3873