Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case-Insensitive handling of AppRole role names #3665

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Case-Insensitive handling of AppRole role names #3665

merged 1 commit into from
Dec 11, 2017

Conversation

vishalnayak
Copy link
Member

@vishalnayak vishalnayak commented Dec 8, 2017 •
edited
Loading

Fixes #3643

This PR ensures that the new approles that get created behave in a case-insensitive manner. It does not attempt to upgrade the secret IDs of existing approles.

@vishalnayak vishalnayak added this to the 0.9.1 milestone Dec 8, 2017
chrishoffman
chrishoffman reviewed Dec 8, 2017
View reviewed changes
Copy link
Contributor

@chrishoffman chrishoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I'm assuming we are not just switching to an case-insensitive lookup because of concerns of some users having incompatible data.

@vishalnayak
Copy link
Member Author

@chrishoffman That's right.

jefferai
jefferai approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would put a note in CHANGES in the changelog explaining the new behavior and that existing roles won't be affected.

@jefferai jefferai merged commit aef8a18 into master Dec 11, 2017
@jefferai jefferai deleted the approle-name-casing branch December 11, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoffman chrishoffman chrishoffman left review comments

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalnayak @jefferai @chrishoffman