Clarify api_addr related errors on VaultPluginTLSProvider #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2017
jefferai
reviewed
Dec 4, 2017
helper/pluginutil/tls.go
Outdated
| @@ -146,19 +146,19 @@ func VaultPluginTLSProvider(apiTLSConfig *api.TLSConfig) func() (*tls.Config, er | |||
|
|
|||
| addrRaw := wt.Claims().Get("addr") | |||
| if addrRaw == nil { | |||
| return nil, errors.New("decoded token does not contain primary cluster address") | |||
| return nil, errors.New("decoded token does not contain primary cluster api_address") | |||
There was a problem hiding this comment.
This error message isn't really good (originally, not due to your change) -- it's not really "primary cluster" it's "active node". But really just, the originating Vault process.
jefferai
reviewed
Dec 4, 2017
| @@ -32,6 +32,9 @@ plugin process' environment. This token is single use and has a short TTL. Once | |||
| unwrapped, it provides the plugin with a uniquely generated TLS certificate and | |||
| private key for it to use to talk to the original vault process. | |||
|
|
|||
| The [`api_addr`][api_addr] must be set in order for the plugin process establish | |||
| communication with the Vault server during mount time. | |||
|
|
|||
There was a problem hiding this comment.
Might want a note here (and below) about when this will be set automatically.
jefferai
previously approved these changes
Dec 4, 2017
briankassouf
reviewed
Dec 5, 2017
helper/pluginutil/tls.go
Outdated
| @@ -146,19 +146,19 @@ func VaultPluginTLSProvider(apiTLSConfig *api.TLSConfig) func() (*tls.Config, er | |||
|
|
|||
| addrRaw := wt.Claims().Get("addr") | |||
| if addrRaw == nil { | |||
| return nil, errors.New("decoded token does not contain primary cluster address") | |||
| return nil, errors.New("decoded token does not contain the active node's api_address") | |||
There was a problem hiding this comment.
If we are going to underscore it here it should probably be api_addr to match the config value
briankassouf
previously approved these changes
Dec 5, 2017
calvn
added a commit
that referenced
this pull request
Dec 5, 2017
* Mention api_addr on VaultPluginTLSProvider logs, update docs * Clarify message and mention automatic api_address detection * Change error message to use api_addr * Change error messages to use api_addr
chrishoffman
pushed a commit
that referenced
this pull request
Dec 6, 2017
* oss/master: changelog++ Support MongoDB session-wide write concern (#3646) Clarify api_addr related errors on VaultPluginTLSProvider (#3620) allowed/disallowed_policies as TypeCommaStringSlice (#3641) Update example payload and response for pem_keys field which needs \n after header and before footer in order to be accepted as a valid RSA or ECDSA public key (#3632) Docs: Update /sys/policies/ re: beta refs to address #3624 (#3629) Update secrets page Remove beta notice Expanding on the quick start guide with how to set up an intermediate authority (#3622) Docs: mlock() notes, fixes #3605 (#3614) Fix spelling (#3609) Add command to example to register plugin (#3601) update relatedtools, add Goldfish UI. (#3597) Fix docs for Transit API (#3588) Update cassandra docs with consistency value. Remove Trailing White space in Kubernetes Doc (#3360) Missing command for vault PUT operation (#3355) Update some rekey docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3612