Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seal type to seal-status output. #3516

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Add seal type to seal-status output. #3516

merged 1 commit into from
Nov 2, 2017

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Nov 1, 2017

@jefferai jefferai added this to the 0.8.4 milestone Nov 1, 2017
@jefferai jefferai requested review from calvn and vishalnayak November 1, 2017 20:12
calvn
calvn reviewed Nov 1, 2017
View reviewed changes
command/status.go
@@ -36,12 +36,14 @@ func (c *StatusCommand) Run(args []string) int {
}

outStr := fmt.Sprintf(
"Sealed: %v\n"+
"Type: %s\n"+
Copy link
Contributor

@calvn calvn Nov 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some weird formatting in here, gofmt to check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fmted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Yeah my bad, realized that the indentation below is intentional.

vishalnayak
vishalnayak approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jefferai jefferai merged commit 962ef74 into master Nov 2, 2017
@jefferai jefferai deleted the seal-type-in-status branch November 2, 2017 02:00
chrishoffman pushed a commit that referenced this pull request Nov 2, 2017
Merge remote-tracking branch 'oss/master' into required-params
34953bb 
* oss/master:
  Add seal type to seal-status output. (#3516)
  Use an atomic store in expiration loading test to fix race detector
  fix deadlock while loading groups (#3515)
  changelog++
  Fix memory leak when a connection would hit the cluster port and go away (#3513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn approved these changes

@vishalnayak vishalnayak vishalnayak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @calvn @vishalnayak