Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude /sys/leases/renew from registering with expiration manager #2891

Merged
merged 2 commits into from
Jun 20, 2017
Merged

Exclude /sys/leases/renew from registering with expiration manager #2891

merged 2 commits into from
Jun 20, 2017

Conversation

chrishoffman
Copy link
Contributor

Fixes #2875

@chrishoffman chrishoffman requested a review from jefferai June 19, 2017 21:42
@jefferai
Copy link
Member

I think there's another issue too. If you look at http/handler.go the sys/renew path chains to handleLogical with the dataOnly flag set to false. But the sys/leases set of functions aren't pulled out there so they'll use the sys/ handling which returns data only. Probably the entire sys/leases/ endpoint needs to be fixed here.

The tests aren't at the API level, they're at the handler level, so they didn't catch this :-/

@jefferai jefferai added this to the 0.7.4 milestone Jun 20, 2017
@chrishoffman
Copy link
Contributor Author

Drat, should have caught that one. I added a bunch of tests that should catch that although if we move the endpoint again we'll have to make sure the duplicate tests are copied too.

@chrishoffman chrishoffman merged commit 31579fc into master Jun 20, 2017
@chrishoffman chrishoffman deleted the issue-2875 branch June 20, 2017 16:34
chrishoffman pushed a commit that referenced this pull request Jun 21, 2017
Merge remote-tracking branch 'oss/master' into db-phy-cockroachdb
3b9b37c 
* oss/master: (161 commits)
  update gitignore
  changelog++
  Exclude /sys/leases/renew from registering with expiration manager (#2891)
  More cleanup
  Clarify/fix some configuration info.
  Add a convenience function for copying a client (#2887)
  Better error messages using ListObjects than using HeadBucket. Might be a bigger request but messages are better than BadRequest, how this changes effect the messages are in the issue (#2892)
  Add ACL info to Consul configuration page
  Return error on bad CORS and add Header specification to API request primitive
  Add Zyborg.Vault PowerShell module to libs list (#2869)
  changelog++
  CouchDB physical backend (#2880)
  Fix root paths test
  Add missing datadog vendored lib
  changelog++
  Fix up CORS.
  Cors headers (#2021)
  Address review feedback
  Fix the test error message
  Added utility on router to fetch mount entry using its ID
  ...
@jefferai jefferai modified the milestones: 0.7.4, 0.8.0 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chrishoffman @jefferai