Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DogStatsD metrics output. #2883

Merged
merged 1 commit into from
Jun 17, 2017
Merged

Add DogStatsD metrics output. #2883

merged 1 commit into from
Jun 17, 2017

Conversation

jefferai
Copy link
Member

Fixes #2490

@jefferai jefferai added this to the 0.7.4 milestone Jun 17, 2017
@jefferai
Copy link
Member Author

Ported directly from Consul. Parsing tests pass, so going to just merge.

@jefferai jefferai merged commit f5de93f into master Jun 17, 2017
@jefferai jefferai deleted the dogstatsd-metrics-output branch June 17, 2017 03:51
@jippi
Copy link
Contributor

jippi commented Jun 17, 2017

I guess this also still uses classic statsd paths rather than tagged metrics paths?

@jefferai
Copy link
Member Author

Maybe?

@saj saj mentioned this pull request Jun 22, 2017
Merged
@jefferai jefferai modified the milestones: 0.7.4, 0.8.0 Jul 24, 2017
@josegonzalez
Copy link
Contributor

Yeah its classic statsd paths. Should be fairly easy to switch to tagged metric paths as shown in this pull request for consul, though it would require at least a minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @jippi @josegonzalez