Creates Skeleton RPC to send global client data to primaries #28761
+59
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
VioletHynes
approved these changes
Oct 24, 2024
vault/activity_log_util.go
Outdated
| @@ -13,3 +13,8 @@ import ( | |||
| func (a *ActivityLog) sendCurrentFragment(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // sendGlobalClients is a no-op on OSS | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates the RPC that will send global client data from a secondary to a primary at any point that Vault is running. We will reuse the same the same RPC when Vault upgrades to 1.19 to send all of the global client data from the secondary to the primary.
To make the PR sizes manageable, this PR only creates the RPC, and sends some "dummy" data to verify that the RPC works. A following PR will be made to create functions to separate the global clients from the local clients and then send that data to the secondaries.
ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6889
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.