Deprecate distinct_entities and nont_entity_tokens #27830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
divyaac
changed the title
divyaac
force-pushed
the
VAULT-20032_Remove_Entitiy_Count_Fields_Update_Docs
branch
from
9955c17 to
d53c1d0
Compare
|
@divyaac can you fix the build? Once that's resolved I'll approve! |
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
* OSS Changes * Added changelog * Fix build errors
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
* OSS Changes * Added changelog * Fix build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSS changes for the ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6056/files#diff-1f4207e699cd95fe7169925fd5b032560c07a1e73005a085e661dac1064dbacf
Removes the deprecated distinct_entities and non_entity_tokens field from code. As seen in the code and in documentation distinct_entities = entity_clients now, and non_entity_tokens=non_entity_clients.
We will also need to remove references to these values from the UI.
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.