-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS secrets: add support for STS session tags #27620
Merged
benashz
merged 5 commits into
main
from
VAULT-18293/aws-secrets-support-sts-session-tags
Jul 2, 2024
Merged
AWS secrets: add support for STS session tags #27620
benashz
merged 5 commits into
main
from
VAULT-18293/aws-secrets-support-sts-session-tags
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jun 26, 2024
benashz
force-pushed
the
VAULT-18293/aws-secrets-support-sts-session-tags
branch
from
June 26, 2024 21:38
fc21e1a
to
4a76371
Compare
CI Results: |
Adds support for configuring session tags for assume role operations.
benashz
force-pushed
the
VAULT-18293/aws-secrets-support-sts-session-tags
branch
from
June 26, 2024 22:13
4a76371
to
8148b7d
Compare
Build Results: |
benashz
force-pushed
the
VAULT-18293/aws-secrets-support-sts-session-tags
branch
from
June 27, 2024 20:19
4174a03
to
b54b183
Compare
vinay-gopalan
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice test coverage 👍🏼
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configuring session tags for assume role operations.
This PR takes over the work started in #18813
See #18813 (comment) for details.
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+ent
labelsinstead of the old style
backport/x.x.x
labels.the normal
backport/x.x.x
label (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.