Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS secrets: add support for STS session tags #27620

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jun 26, 2024

Adds support for configuring session tags for assume role operations.

This PR takes over the work started in #18813

See #18813 (comment) for details.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 26, 2024
@benashz benashz force-pushed the VAULT-18293/aws-secrets-support-sts-session-tags branch from fc21e1a to 4a76371 Compare June 26, 2024 21:38
Copy link

github-actions bot commented Jun 26, 2024

CI Results:
All Go tests succeeded! ✅

Adds support for configuring session tags for assume role operations.
@benashz benashz force-pushed the VAULT-18293/aws-secrets-support-sts-session-tags branch from 4a76371 to 8148b7d Compare June 26, 2024 22:13
@benashz benashz marked this pull request as ready for review June 27, 2024 13:54
@benashz benashz requested review from a team as code owners June 27, 2024 13:54
@benashz benashz requested a review from robmonte June 27, 2024 13:54
Copy link

github-actions bot commented Jun 27, 2024

Build Results:
All builds succeeded! ✅

@tomcf-hcp tomcf-hcp modified the milestones: 1.17.1, 1.17.2 Jun 27, 2024
@benashz benashz force-pushed the VAULT-18293/aws-secrets-support-sts-session-tags branch from 4174a03 to b54b183 Compare June 27, 2024 20:19
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice test coverage 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants