Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI fix KVv2 in json editor when value is null into release/1.16.x #27116

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #27094 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


  • ent test pass
  • test coverage

Regression PR #24530
Fixes Issue #26709

Note: confirmed that you can in fact pass null as a value using curl, so this was a situation we needed to allow in the UI.

Before:

before.mov

After:

fixed.mov

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-27209/fix-json-kv-when-value-null/marginally-vital-walleye branch from 7b06632 to fe5aadf Compare May 17, 2024 16:46
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 17, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip added the ui label May 17, 2024
@Monkeychip Monkeychip added this to the 1.16.3 milestone May 17, 2024
@Monkeychip Monkeychip enabled auto-merge (squash) May 17, 2024 18:02
@Monkeychip Monkeychip merged commit 0f9d472 into release/1.16.x May 17, 2024
25 of 27 checks passed
@Monkeychip Monkeychip deleted the backport/ui/VAULT-27209/fix-json-kv-when-value-null/marginally-vital-walleye branch May 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants