Add ExternalID support to AWS Auth STS configuration #26628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
|
There probably should be a milestone, but the internal JIRA issue doesn't have one (yet?) |
schavis
requested changes
Apr 30, 2024
Co-authored-by: Sarah Chavis <[email protected]>
thyton
reviewed
May 1, 2024
| stsReq.Data = data | ||
| // create another entry to test the list operation | ||
| stsReq.Data = data2 | ||
| // create another entry with alternate data to test ExternalID and LIST |
There was a problem hiding this comment.
If possible, could we add a block for checking "external_id": "fake_id" existence in a read response before line 1455?
There was a problem hiding this comment.
added a response check for data2
|
@kpcraig I'm assuming the update is meant for 1.17, but if it's not, don't forget to add the relevant backport labels for 1.16, 1.15, and/or 1.14 so the update publishes to the correct docset :) |
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 20, 2024
external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628
Merged
2 tasks
helenfufu
added a commit
to hashicorp/terraform-provider-vault
that referenced
this pull request
Nov 22, 2024
* add external_id to aws_auth_backend_sts_role resource * update docs for aws_auth_backend_sts_role resource * update acceptance tests * only support external_id on vault versions >= 1.17 external_id support for aws auth sts configuration added in 1.17.0: hashicorp/vault#26628 * separate import test for external_id case * update changelog * fix changelog: move change under unreleased * add import test steps and remove separate import tests, add separate withExternalID test * handle error on d.Set * rename testAccAWSAuthBackendSTSRoleConfig_basic to more general testAccAWSAuthBackendSTSRoleConfig * note 1.17 version requirement in doc Co-authored-by: vinay-gopalan <[email protected]> --------- Co-authored-by: vinay-gopalan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ExternalIDs to be included in assume-role requests.