Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update userpass validations to handle password_hash #26577

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Apr 22, 2024

Userpass has a new way of adding or updating the user's password: password_hash. This PR updates the validation on userpass auth method in the following ways:

  • move the validation check to on submit instead of key up, to match how our other forms work
  • If editing a user, skip validation and let the API return the error if there is one
  • If password AND password_hash are blank on a new user, show the validation message and prevent API request
  • If password AND password_hash are present on a new user, show the validation message and prevent API request

9f37e251ab0cd46151ee0c5cb764090e

  • Ent tests pass

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 22, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw added this to the 1.17.0-rc milestone Apr 22, 2024
@hashishaw hashishaw added the ui label Apr 22, 2024
@hashishaw hashishaw marked this pull request as ready for review April 22, 2024 16:13
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hashishaw hashishaw merged commit 0a505f9 into main Apr 22, 2024
38 of 51 checks passed
@hashishaw hashishaw deleted the ui/VAULT-25255/update-userpass-password-validation branch April 22, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants