During a seal reload through SIGHUP, only write updated seal barrier on an active node #26381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on non-active nodes
github-actions
bot
added
the
hashicorp-contributed-pr
sgmiller
approved these changes
Apr 11, 2024
|
CI Results: |
|
Build Results: |
stevendpclark
deleted the
stevendpclark/vault-25623-seal-ha-sighup-err-readonly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
enable_multisealwas enabled, along with a configured auto-seal on enterprise standby nodes, if a SIGHUP were sent to Vault the seal config would be read and if modified would attempt to update the local seal barrier only to get an ErrReadOnly error.Trap the case on standby nodes, we load seal config but throw it away as we won't use it, on perf standby's we update the core barrier information in memory while on active nodes we perform the update as we did before.