Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-24798: Audit - error tweak #26362

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

peteski22
Copy link

@peteski22 peteski22 commented Apr 11, 2024

Don't wrap the underlying error on filter field validation failure.

Once the Operator has seen:

filter references an unsupported field: foo == bar: invalid configuration

... then the following 'extra' info isn't really useful at all:

error finding value in datum: /foo at part 0: couldn't find key: struct field with name "foo"

We document the filter fields for Vault Operators: filter properties for audit devices.

Before:
image

After:
image

  • Please ignore the sneaky bar in screenshots, which goes against what we document (should be \"bar\")

Copy link

github-actions bot commented Apr 11, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteski22 peteski22 merged commit c96c1ef into main Apr 11, 2024
103 of 104 checks passed
@peteski22 peteski22 deleted the peteski22/audit/error-tweak branch April 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/audit hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants