Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Dependency bumps 1.17.x #26346

Merged
merged 20 commits into from
Apr 12, 2024
Merged

UI: Dependency bumps 1.17.x #26346

merged 20 commits into from
Apr 12, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Apr 10, 2024

We had a number of outdated upstream dependencies. In order to resolve these, I first deleted yarn.lock and then re-ran yarn install, which updated the following nested packages to an acceptable version:

Other dependencies needed specific resolutions:

async @ 2.6.4

An old version of async was required by fireworm, which is only consumed by testem. We are on the latest version of testem (3.12.0), so the best way to resolve this is to pin async@^2.6.4 which matches the version already imported to the codebase.
yarn why async showing fireworm@0.7.2 requiring async@0.2.10

nth-check @ 2.1.1

An old version of nth-check is a nested dependency of ember-svg-jar which is currently used to display some SVGs that are not available from HDS. I first tried to pin the css-select dependency but that caused build errors. Pinning nth-check directly allowed the UI to build, although there were typescript errors that I resolved in the next commit
yarn why nth-check showing requirement by svgo

ansi-html @ 0.0.8

The requirement for this dependency is ^0.0.7 which should have resolved to 0.0.8 but it seems like yarn doesn't know anything about the package, because when I do yarn info ansi-html it has returns with:

Usage Error: No package matched your request

I pinned it and that seems to resolve and build fine.
yarn why ansi-html showing requirement ^0.0.7

ember-template-lint

Lint jobs were failing with a mysterious error on this branch, so I updated ember-template-lint to 6.0.0 and it was working again. I added the failing lint checks to the template-lintrc file, and will fix the automatic ones in a separate PR so this can be backported

d3 deps

I removed ember-d3 which is unnecessary since we are pulling in the d3 libraries we need. I was able to update all of the d3 libraries we use without issue

- mout VAULT-25595 VAULT-25603
- follow-redirects VAULT-25605
- terser VAULT-25594 VAULT-25593
- minimatch VAULT-25591
- loader-utils VAULT-25216 VAULT-25590 VAULT-25589 VAULT-25588 VAULT-25587
- decode-uri-component VAULT-25586
- qs VAULT-25585
- @xmldom/xmldom VAULT-25217
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 10, 2024
@hashishaw hashishaw added this to the 1.16.2 milestone Apr 10, 2024
@hashishaw hashishaw marked this pull request as ready for review April 10, 2024 16:38
Copy link

github-actions bot commented Apr 10, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@andaley andaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work resolving so many of these at once!

@hashishaw hashishaw force-pushed the ui/dependency-bumps branch from 5fc1f1f to 9a73400 Compare April 10, 2024 22:00
@hashishaw hashishaw changed the title UI: bump dependencies UI: Dependency bumps 1.17.x Apr 11, 2024
@hashishaw hashishaw modified the milestones: 1.16.2, 1.17.0-rc Apr 11, 2024
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! ✨ Thank you for the thorough PR description

@hashishaw hashishaw enabled auto-merge (squash) April 11, 2024 16:30
@hashishaw hashishaw merged commit 52c0dc8 into main Apr 12, 2024
26 checks passed
@hashishaw hashishaw deleted the ui/dependency-bumps branch April 12, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants