Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -self flag to token-revoke #2596

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Add -self flag to token-revoke #2596

merged 1 commit into from
Apr 17, 2017

Conversation

cblecker
Copy link
Contributor

Fixes #2493.

Adds a -self flag to token-revoke.

jefferai
jefferai reviewed Apr 17, 2017
View reviewed changes
command/token_revoke.go Outdated
c.Ui.Error(fmt.Sprintf(
"\ntoken-revoke expects no arguments when revoking self"))
return 1
case len(args) != 1 && !self:
flags.Usage()
c.Ui.Error(fmt.Sprintf(
"\ntoken-revoke expects one argument"))
Copy link
Member

@jefferai jefferai Apr 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably say "expects one argument or the 'self' flag"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

@jefferai
Copy link
Member

One minor update, looks good otherwise

@jefferai jefferai added this to the 0.7.1 milestone Apr 17, 2017
@jefferai
Copy link
Member

Thanks!

@jefferai jefferai merged commit 377640d into hashicorp:master Apr 17, 2017
@cblecker cblecker deleted the revoke-self branch April 17, 2017 16:41
chrishoffman pushed a commit that referenced this pull request Apr 18, 2017
Merge remote-tracking branch 'oss/master' into type-string-slice
c081897 
* oss/master:
  Fix azure test round 2
  Fix test for changed Azure
  changelog++
  Add -self flag to token-revoke (#2596)
  Update revoke.html.md (#2604)
  Update to new Azure code after dep update (#2603)
  changelog++
  Added "Domain" configuration parameter to Swift provider to enable V3 authentication (#2554)
  Fix cassandra dep breakage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai left review comments

@vishalnayak vishalnayak vishalnayak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cblecker @jefferai @vishalnayak