Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Remove leading slash from kv version 2 secret path into release/1.15.x #25884

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #25874 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


Typically we avoid sanitizing in the UI to minimize data manipulation, however we decided to strip secret paths of the leading slash to copy CLI functionality.

 vault kv put -mount=kv /my-secret foo=my-long-passcode
== Secret Path ==
kv/data/my-secret

======= Metadata =======
Key                Value
---                -----
created_time       2024-03-11T16:59:42.502882Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            1
⇒ vault kv put -mount=kv //my-secret foo=my-long-passcode
== Secret Path ==
kv/data/my-secret

======= Metadata =======
Key                Value
---                -----
created_time       2024-03-11T17:00:01.047652Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            2


---

<details>
<summary> Overview of commits </summary>

  - 0d71b2a3ddd9e5651d861f36091f3e084cd21c96 

</details>


@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-24467/remove-leading-slash-kv-secret-path/actively-known-grouper branch from 8884bba to 869df96 Compare March 12, 2024 14:35
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 12, 2024
@hellobontempo hellobontempo modified the milestones: 1.17.0, 1.15.7 Mar 12, 2024
@hellobontempo hellobontempo enabled auto-merge (squash) March 12, 2024 14:39
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit 0d9a988 into release/1.15.x Mar 12, 2024
26 of 27 checks passed
@hellobontempo hellobontempo deleted the backport/ui/VAULT-24467/remove-leading-slash-kv-secret-path/actively-known-grouper branch March 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants