Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Correctly call resultant-acl endpoint when user root is root #25766

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

hashishaw
Copy link
Contributor

In #25256 we updated the permissions adapter logic to call the resultant-acl endpoint with the user's namespace, if it exists. However, the logic did not work for users in the root namespace who log into a child namespace. Now it does, with test coverage.

@hashishaw hashishaw added this to the 1.16.0 milestone Mar 4, 2024
@hashishaw hashishaw added the bug Used to indicate a potential bug label Mar 4, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@hashishaw hashishaw marked this pull request as ready for review March 5, 2024 17:26
@hashishaw hashishaw enabled auto-merge (squash) March 5, 2024 17:26
Copy link

github-actions bot commented Mar 5, 2024

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants