Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add notes around OCSP GET request issue into release/1.14.x #25757

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #25745 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@stevendpclark
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


  • Fix some broken TOC links
  • Add a note in the api-docs and in the considerations page around Vault having issues with OCSP GET requests and that POST requests should be preferred.
  • Add existing known issue to all branches that are affected.

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

CI Results:
All Go tests succeeded! ✅

@stevendpclark stevendpclark force-pushed the backport/docs/stevendpclark/add-ocsp-get-note/factually-epic-escargot branch from 256a07d to 4c7bd6a Compare March 1, 2024 20:46
@stevendpclark stevendpclark self-assigned this Mar 1, 2024
@stevendpclark stevendpclark marked this pull request as ready for review March 1, 2024 20:47
@stevendpclark stevendpclark requested review from a team as code owners March 1, 2024 20:47
Copy link

github-actions bot commented Mar 1, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevendpclark stevendpclark merged commit 493ca85 into release/1.14.x Mar 4, 2024
48 of 50 checks passed
@stevendpclark stevendpclark deleted the backport/docs/stevendpclark/add-ocsp-get-note/factually-epic-escargot branch March 4, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants