Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-24556: add secret syncs to vault operator usage output #25751

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

miagilepner
Copy link
Contributor

No description provided.

@miagilepner miagilepner added this to the 1.16.0-rc3 milestone Mar 1, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 1, 2024
@miagilepner miagilepner requested a review from a team March 1, 2024 17:16
Copy link

github-actions bot commented Mar 1, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Mar 1, 2024

CI Results:
All Go tests succeeded! ✅

@miagilepner miagilepner requested a review from akshya96 March 1, 2024 17:18
command/operator_usage.go Outdated Show resolved Hide resolved
@miagilepner miagilepner marked this pull request as draft March 1, 2024 17:33
@@ -242,6 +242,9 @@ func (c *OperatorUsageCommand) parseNamespaceCount(rawVal interface{}) (UsageRes
return ret, errors.New("missing non_entity_tokens")
}

// don't error if secret syncs are 0
ret.secretSyncs, _ = jsonNumberOK(counts, "secret_syncs")
Copy link
Contributor

@akshya96 akshya96 Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, My question is unrelated to this PR but I am curious if there no possibility to have 0 distinct entities?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should make this comment clearer. The problem isn't that there are 0, it's that secret_syncs isn't a key in the output. This could happen if your Vault CLI version is newer than your Vault server version.

@miagilepner miagilepner marked this pull request as ready for review March 4, 2024 10:32
@miagilepner miagilepner enabled auto-merge (squash) March 4, 2024 10:47
@miagilepner miagilepner merged commit e3d8a4d into main Mar 4, 2024
90 checks passed
@miagilepner miagilepner deleted the miagilepner/operator-usage-secret-syncs branch March 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants