Sync UI: Add granularity to sync destinations #25500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
Monkeychip
reviewed
Feb 17, 2024
Monkeychip
reviewed
Feb 17, 2024
ui/lib/sync/addon/components/secrets/page/destinations/destination/sync.hbs
Show resolved
Hide resolved
Monkeychip
approved these changes
Feb 17, 2024
hellobontempo
commented
Feb 17, 2024
| <span>{{or val.label val.value val}}</span> | ||
| {{or val.label val.value val}} | ||
| {{#if val.helpText}} | ||
| <Hds::TooltipButton @text={{val.helpText}} aria-label="More information"> |
There was a problem hiding this comment.
I used Hds here because InfoTooltip styling was too low and didn't have the patience to CSS
hellobontempo
commented
Feb 17, 2024
| @@ -38,6 +38,11 @@ | |||
| Select a KV engine mount and path to sync a secret to the | |||
| {{@destination.typeDisplayName}} | |||
| destination. Selecting a previously synced secret will re-sync that secret. | |||
| {{#if (eq @destination.granularity "secret-key")}} | |||
hellobontempo
commented
Feb 17, 2024
| <li> | ||
| <LinkTo | ||
| class="has-text-black has-text-weight-semibold" | ||
| <Item.menu @hasMenu={{false}}> |
There was a problem hiding this comment.
@hasMenu is false so that we can use the Hds::Dropdown istead of PopupMenu
hellobontempo
commented
Feb 17, 2024
There was a problem hiding this comment.
replaced destinations popup menu so the views were consistent
hellobontempo
commented
Feb 17, 2024
zofskeez
approved these changes
Feb 20, 2024
zofskeez
deleted the
ui/VAULT-24177/add-granularity-to-sync-destinations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI updates adding
granularityfield to a sync destination.secret keybadge to list viewHds::Dropdownso that adding copy to the popup menu was cleaner