UI: add deletion_allowed to transform, add tokenization transform type #25436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
hellobontempo
commented
Feb 15, 2024
| const base = `${this.buildURL()}/${encodePath(backend)}`; | ||
| // when type exists, transformations is plural | ||
| const url = type ? `${base}/transformations/${type}` : `${base}/transformation`; | ||
| if (id) return `${url}/${encodePath(id)}`; |
There was a problem hiding this comment.
I find url easier to read this way, but I can revert to url = url + '/' + encodePath(id); if folks prefer that! I don't have strong feelings 😄
hellobontempo
commented
Feb 15, 2024
| @@ -83,12 +86,49 @@ export default Model.extend({ | |||
| subText: 'Search for an existing role, type a new role to create it, or use a wildcard (*).', | |||
| wildcardLabel: 'role', | |||
| }), | |||
| deletion_allowed: attr('boolean', { | |||
There was a problem hiding this comment.
Wrote these params based on the docs - so a second set of eyes checking them for typos/accuracy would be helpful!
hashishaw
approved these changes
Feb 16, 2024
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.6 general requests to
/transform(without:type) as part of the URL was deprecated docsI decided against glimmerizing for backportability since this will go back to every supported release. Changes in this PR include:
deletion_allowedto all transform typestokenizationand associated params:typeendpoint (e.g./transform/transformations/fpe/:nameenterprise tests ✅
📷