Cache trusted cert values, invalidating when anything changes #25421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
|
Converting to draft to add cache sizing and unit tests, docs |
…mory. Add docs, unit tests
stevendpclark
approved these changes
Feb 15, 2024
| @@ -646,6 +657,13 @@ func (b *backend) loadTrustedCerts(ctx context.Context, storage logical.Storage, | |||
| conf.QueryAllServers = conf.QueryAllServers || entry.OcspQueryAllServers | |||
| } | |||
| } | |||
|
|
|||
| b.trustedCache.Add(certName, &trusted{ | |||
There was a problem hiding this comment.
nit: Should this only happen if !b.trustedCacheDisabled
There was a problem hiding this comment.
Definitely, otherwise we're just wasting memory.
…e the disabled an atomic
stevendpclark
approved these changes
Feb 15, 2024
sgmiller
added a commit
that referenced
this pull request
Feb 15, 2024
* Cache trusted cert values, invalidating when anything changes * rename to something more indicative * defer * changelog * Use an LRU cache rather than a static map so we can't use too much memory. Add docs, unit tests * Don't add to cache if disabled. But this races if just a bool, so make the disabled an atomic
sgmiller
added a commit
that referenced
this pull request
Feb 15, 2024
* Cache trusted cert values, invalidating when anything changes * rename to something more indicative * defer * changelog * Use an LRU cache rather than a static map so we can't use too much memory. Add docs, unit tests * Don't add to cache if disabled. But this races if just a bool, so make the disabled an atomic
sgmiller
added a commit
that referenced
this pull request
Feb 20, 2024
#25464) * Cache trusted cert values, invalidating when anything changes * rename to something more indicative * defer * changelog * Use an LRU cache rather than a static map so we can't use too much memory. Add docs, unit tests * Don't add to cache if disabled. But this races if just a bool, so make the disabled an atomic
sgmiller
added a commit
that referenced
this pull request
Feb 20, 2024
#25465) * Cache trusted cert values, invalidating when anything changes * rename to something more indicative * defer * changelog * Use an LRU cache rather than a static map so we can't use too much memory. Add docs, unit tests * Don't add to cache if disabled. But this races if just a bool, so make the disabled an atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, trusted certs were loaded and parsed on every login call. This
is both slow, and means a copy of the trusted certs is in memory per login.
For highly concurrent use this raises Vault's memory usage unnecessarily.