Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Make empty state links consistent #25209

Merged
merged 4 commits into from
Feb 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/25209.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fix inconsistent empty state action link styles
```
11 changes: 6 additions & 5 deletions ui/app/components/clients/no-data.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
@message="Tracking is disabled, and no data is being collected. To turn it on, edit the configuration."
>
{{#if @config.canEdit}}
<p>
<LinkTo @route="vault.cluster.clients.config">
Go to configuration
</LinkTo>
</p>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="Go to configuration"
@route="vault.cluster.clients.config"
/>
{{/if}}
</EmptyState>
{{/if}}
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,12 @@
@message="Access secret engine actions easily. Enable a compatible secret engine (such as database, KV version 2, or PKI) to get started."
data-test-empty-state="quick-actions"
>
<div>
<LinkTo @route="vault.cluster.settings.mount-secret-backend">Enable a secret engine</LinkTo>
</div>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="Enable a secrets engine"
@route="vault.cluster.settings.mount-secret-backend"
/>
</EmptyState>
{{/if}}
</Hds::Card::Container>
9 changes: 6 additions & 3 deletions ui/app/templates/components/dashboard/replication-card.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,12 @@
class="has-top-margin-m"
data-test-empty-state="replication"
>
<div>
<LinkTo @route="vault.cluster.replication">Enable replication</LinkTo>
</div>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="Enable replication"
@route="vault.cluster.replication"
/>
</EmptyState>
{{/if}}
</Hds::Card::Container>
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,12 @@
class="has-top-margin-m"
data-test-empty-state="secrets-engines"
>
<div>
<LinkTo @route="vault.cluster.settings.mount-secret-backend">Enable a secret engine</LinkTo>
</div>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="Enable a secrets engine"
@route="vault.cluster.settings.mount-secret-backend"
/>
</EmptyState>
{{/if}}
</Hds::Card::Container>
12 changes: 7 additions & 5 deletions ui/app/templates/components/database-connection.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -308,11 +308,13 @@
@message="This database type cannot be viewed in the UI. You will have to use the API or CLI to perform actions here."
@bottomBorder={{true}}
>
<LinkTo @route="vault.cluster.secrets.backend.list-root" class="link">
<Chevron @direction="left" />
Go back
</LinkTo>
<DocLink @path="/api/secret/databases">Documentation</DocLink>
<Hds::Link::Standalone @icon="chevron-left" @text="Go back" @route="vault.cluster.secrets.backend.list-root" />
<Hds::Link::Standalone
@icon="docs-link"
@iconPosition="trailing"
@text="Database API docs"
@href={{doc-link "/vault/api-docs/secret/databases"}}
/>
</EmptyState>
{{else}}
{{#each @model.showAttrs as |attr|}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
@iconPosition="trailing"
@icon="docs-link"
@text="Database documentation"
@href={{doc-link "/vault/docs/secrets/databases"}}
@href={{doc-link "/vault/api-docs/secret/databases"}}
/>
</EmptyState>
{{/unless}}
Expand Down
17 changes: 8 additions & 9 deletions ui/app/templates/components/identity/item-metadata.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,15 @@
{{else}}
<EmptyState
@title="No metadata for {{@model.name}}"
@message="You can store custom data that you want to associate with a {{lowercase
@message='You can store custom data that you want to associate with this {{lowercase
(humanize @model.identityType)
}}. Edit this {{lowercase (humanize @model.identityType)}} to get started."
}}. Click "Edit {{lowercase (humanize @model.identityType)}}" to get started.'
>
<LinkTo @route="vault.cluster.access.identity.edit" @model={{@model.id}} class="link">
Edit
{{lowercase (humanize @model.identityType)}}
</LinkTo>
<DocLink @path="/vault/tutorials/auth-methods/identity">
Learn more
</DocLink>
<Hds::Link::Standalone
@text="Identity: entities and groups tutorial"
@href={{doc-link "/vault/tutorials/auth-methods/identity"}}
@icon="learn-link"
@iconPosition="trailing"
/>
</EmptyState>
{{/each-in}}
9 changes: 6 additions & 3 deletions ui/app/templates/components/keymgmt/provider-edit.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,12 @@
@title="No keys for this provider"
@message="Keys for this provider will be listed here. Add a key to get started."
>
<SecretLink @mode="create" @secret="" @queryParams={{hash itemType="key"}} class="link">
Create key
</SecretLink>
<Hds::Link::Standalone
@icon="plus"
@text="Create key"
@route="vault.cluster.secrets.backend.create-root"
@query={{hash itemType="key"}}
/>
</EmptyState>
{{/if}}
{{/let}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,13 @@
@title="No {{this.identityType}} aliases yet"
@message="A list of {{this.identityType}} aliases in this namespace will be listed here. Choose one of the {{pluralize
this.identityType
}} and click &quot;Create Alias&quot; to get started."
}} and click &quot;Add alias&quot; to get started."
>
<LinkTo @route="vault.cluster.access.identity.create" @model={{pluralize this.identityType}} class="link">
Create
{{this.identityType}}
</LinkTo>
<DocLink @path="/vault/tutorials/auth-methods/identity">
Learn more
</DocLink>
<Hds::Link::Standalone
@text="Identity: entities and groups tutorial"
@href={{doc-link "/vault/tutorials/auth-methods/identity"}}
@icon="learn-link"
@iconPosition="trailing"
/>
</EmptyState>
{{/if}}
6 changes: 0 additions & 6 deletions ui/app/templates/vault/cluster/access/identity/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@
this.identityType
}} in this namespace will be listed here. Create your first {{this.identityType}} to get started."
>
<Hds::Link::Standalone
@text="Create {{this.identityType}}"
@icon="plus"
@route="vault.cluster.access.identity.create"
@model={{pluralize this.identityType}}
/>
<Hds::Link::Standalone
@text="Identity: entities and groups tutorial"
@href={{doc-link "/vault/tutorials/auth-methods/identity"}}
Expand Down
8 changes: 2 additions & 6 deletions ui/app/templates/vault/cluster/access/leases/error.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,14 @@
@title="No leases with that ID"
@message="Unable to find lease for the ID &quot;{{this.model.keyId}}&quot;. Try going back to the lookup and re-entering the ID."
>
<LinkTo @route="vault.cluster.access.leases" class="link">
Back to lookup
</LinkTo>
<Hds::Link::Standalone @icon="chevron-left" @text="Back to lookup" @route="vault.cluster.access.leases" />
</EmptyState>
{{else if (eq this.model.httpStatus 403)}}
<EmptyState
@title="You don't have access to a lease with that ID"
@message="If you think you've reached this page in error, please contact your administrator."
>
<LinkTo @route="vault.cluster.access.leases" class="link">
Back to lookup
</LinkTo>
<Hds::Link::Standalone @icon="chevron-left" @text="Back to lookup" @route="vault.cluster.access.leases" />
</EmptyState>
{{else}}
{{#each this.model.errors as |error|}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@
@title="No available providers"
@message="Edit an existing provider or create a new one to allow this application access for authentication requests."
>
<LinkTo @route="vault.cluster.access.oidc.providers">
View providers
</LinkTo>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="View providers"
@route="vault.cluster.access.oidc.providers"
/>
</EmptyState>
{{/if}}
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@
@title="No applications allowed"
@message="Access to this key has been limited, and no applications are allowed to use it. Edit the key to allow access."
>
<LinkTo @route="vault.cluster.access.oidc.keys.key.edit">
Edit key
</LinkTo>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="Edit key"
@route="vault.cluster.access.oidc.keys.key.edit"
/>
</EmptyState>
{{/if}}
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@
@title="No applications allowed"
@message="Access to this provider has been limited, and no applications are allowed to use it. Edit the provider to allow access."
>
<LinkTo @route="vault.cluster.access.oidc.providers.provider.edit">
Edit provider
</LinkTo>
<Hds::Link::Standalone
@icon="chevron-right"
@iconPosition="trailing"
@text="Edit provider"
@route="vault.cluster.access.oidc.providers.provider.edit"
/>
</EmptyState>
{{/if}}
24 changes: 11 additions & 13 deletions ui/app/templates/vault/cluster/access/oidc/scopes/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,16 @@
</LinkedBlock>
{{/each}}
{{else}}
<EmptyState @title="No scopes yet" data-test-oidc-scope-empty-state>
<div>
<p>Use scope to define identity information about the authenticated user.
<DocLink @path="/vault/docs/concepts/oidc-provider#scopes">
Learn more.
</DocLink>
</p>
<div class="has-top-margin-m">
<LinkTo @route="vault.cluster.access.oidc.scopes.create" data-test-oidc-scope-create-empty-state>
Create scope
</LinkTo>
</div>
</div>
<EmptyState
@title="No scopes yet"
@message="Use scope to define identity information about the authenticated user."
data-test-oidc-scope-empty-state
>
<Hds::Link::Standalone
@iconPosition="trailing"
@icon="docs-link"
@text="OIDC provider scopes"
@href={{doc-link "/vault/docs/concepts/oidc-provider#scopes"}}
/>
</EmptyState>
{{/if}}
10 changes: 6 additions & 4 deletions ui/app/templates/vault/cluster/access/reset-password-error.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
</PageHeader>

<EmptyState @title="No password reset access" @message={{this.model.message}}>
<p>
Learn more
<DocLink @path="vault/api-docs/auth/userpass#update-password-on-user">about updating passwords</DocLink>
here.</p>
<Hds::Link::Standalone
@iconPosition="trailing"
@icon="docs-link"
@text="Update password API docs"
@href={{doc-link "/vault/api-docs/auth/userpass#update-password-on-user"}}
/>
</EmptyState>
25 changes: 15 additions & 10 deletions ui/app/templates/vault/cluster/policies/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -161,16 +161,21 @@
this.policyType
}} policy to get started."
>
<LinkTo @route="vault.cluster.policies.create" class="link">
Create
{{uppercase this.policyType}}
policy
<Chevron />
</LinkTo>
<DocLink @path="/vault/tutorials/getting-started/getting-started-policies">
Learn more
<Chevron />
</DocLink>
{{#if (eq this.policyType "acl")}}
<Hds::Link::Standalone
@iconPosition="trailing"
@icon="learn-link"
@text="Getting started with policies"
@href={{doc-link "/vault/tutorials/getting-started/getting-started-policies"}}
/>
{{else}}
<Hds::Link::Standalone
@iconPosition="trailing"
@icon="learn-link"
@text="Sentinel policies tutorial"
@href={{doc-link "/vault/tutorials/policies/sentinel"}}
/>
{{/if}}
</EmptyState>
{{/if}}
{{else}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,14 @@
@bottomBorder={{true}}
class="is-shadowless"
>
<Hds::ButtonSet>
<Hds::Link::Standalone @icon="chevron-left" @text="Go back" @route="vault.cluster.secrets.backends" />
<Hds::Link::Standalone
@icon="learn-link"
@iconPosition="trailing"
@color="secondary"
@text="Disaster recovery tutorial"
@href={{doc-link "/vault/tutorials/enterprise/disaster-recovery"}}
/>
</Hds::ButtonSet>
<Hds::Link::Standalone @icon="chevron-left" @text="Go back" @route="vault.cluster.secrets.backends" />
<Hds::Link::Standalone
@icon="learn-link"
@iconPosition="trailing"
@color="secondary"
@text="Disaster recovery tutorial"
@href={{doc-link "/vault/tutorials/enterprise/disaster-recovery"}}
/>
</EmptyState>
{{else}}
<Page.dashboard
Expand Down
18 changes: 8 additions & 10 deletions ui/app/templates/vault/cluster/replication-dr-promote/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,14 @@
@icon="alert-circle"
@bottomBorder={{true}}
>
<Hds::ButtonSet>
<Hds::Link::Standalone @icon="chevron-left" @text="Go back" @route="vault.cluster.secrets.backends" />
<Hds::Link::Standalone
@icon="learn-link"
@iconPosition="trailing"
@color="secondary"
@text="Disaster recovery tutorial"
@href={{doc-link "/vault/tutorials/enterprise/disaster-recovery"}}
/>
</Hds::ButtonSet>
<Hds::Link::Standalone @icon="chevron-left" @text="Go back" @route="vault.cluster.secrets.backends" />
<Hds::Link::Standalone
@icon="learn-link"
@iconPosition="trailing"
@color="secondary"
@text="Disaster recovery tutorial"
@href={{doc-link "/vault/tutorials/enterprise/disaster-recovery"}}
/>
</EmptyState>
{{else}}
<section>
Expand Down
Loading
Loading