Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for larger transactions in Raft #24991

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

banks
Copy link
Member

@banks banks commented Jan 23, 2024

This is the OSS version of an already-approved change in Vault Enterprise.

It allows different Transactional Storage backends to advertise their own transaction size limits rather than assuming Consul's limits for everything. In practice this means that our Raft-based internal storage can accept larger transactions which can improve performance in Vault Enterprise which uses the transactional interface extensively for writes.

@banks banks added this to the 1.16.0-rc1 milestone Jan 23, 2024
@banks banks requested a review from raskchanky January 23, 2024 10:50
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 23, 2024
@banks banks removed pr/no-changelog hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jan 23, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 23, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banks banks merged commit 2d88a45 into main Jan 24, 2024
110 checks passed
@banks banks deleted the f/raft-group-commit-limit branch January 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants