WIF support for AWS secrets engine #24987
Merged
+224
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
vinay-gopalan
commented
Jan 22, 2024
|
CI Results: |
|
Build Results: |
austingebauer
approved these changes
Jan 29, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Jan 30, 2024
* add new plugin wif fields to AWS Secrets Engine * add changelog * go get awsutil v0.3.0 * fix up changelog * fix test and field parsing helper * godoc on new test * require role arn when audience set * make fmt --------- Co-authored-by: Austin Gebauer <[email protected]> Co-authored-by: Austin Gebauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plugin WIF support to the AWS secrets engine. This adds the following new fields to the
config/rootendpoint to enable configuring Workload Identity Federation:identity_token_audienceidentity_token_ttlrole_arnThe PR also adds a test to ensure that these fields can be set/read to the config and that providing mutually exclusive fields results in an error.
The PR also adds the
PluginIdentityTokenFetcherthat fetches the plugin identity token and passes it to theawsutilpackage to generate a credential chain. The full functionality of this feature is linked to this PR on thego-secure-stdlib: PR link, and will be available when those updates are merged and pulled into Vault.