UI: Update flight icons #24823
Merged
UI: Update flight icons #24823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hashishaw
commented
Jan 11, 2024
There was a problem hiding this comment.
Not totally sure this PR needs a changelog, open to suggestions
There was a problem hiding this comment.
I think a changelog is a good idea. It's a visual enough change that some customers may notice and look for the cause.
|
Build Results: |
Monkeychip
reviewed
Jan 11, 2024
| }} | ||
| class="has-text-grey-light" | ||
| /> | ||
| <Icon @name={{method.icon}} class="has-text-grey-light" /> |
Monkeychip
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our icon usage to eliminate the need for structure icons 🎉
We still have 2 custom icons (
duoandpingid) that prevent us from eliminating svg-jar completely.Auth mount before / after
Engine mount before / after
Dashboard secrets engine card also includes color icons when available
KMIP role operations before / after
