database: Emit event notifications #24718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
tomhjp
approved these changes
Jan 12, 2024
| if err == nil { | ||
| b.dbEvent(ctx, "rotate-root", req.Path, name, true) | ||
| } else { | ||
| b.dbEvent(ctx, "rotate-root-fail", req.Path, name, false) |
There was a problem hiding this comment.
The failure modes are unlikely, but I think it should be possible for modified to be true in this case, if for example the write to storage fails after the password successfully got updated. I think the same is true for a couple of other APIs as well.
| @@ -585,6 +600,34 @@ func TestBackend_basic(t *testing.T) { | |||
| t.Fatalf("Creds should not exist") | |||
| } | |||
| } | |||
| assert.Equal(t, 9, len(eventSender.Events)) | |||
| assert.Equal(t, "database/config-write", string(eventSender.Events[0].Type)) | |||
There was a problem hiding this comment.
nit: Would be nice to use a for loop to reduce the copy-paste/visual noise here :)
added 4 commits
February 5, 2024 10:03
Including for failures to write credentials and failure to rotate.
swenson
force-pushed
the
vault-21858/rotate-fail-events/vault-16968/database-events
branch
from
a8298b0 to
14979e8
Compare
|
Thanks! |
swenson
deleted the
vault-21858/rotate-fail-events/vault-16968/database-events
branch
Monkeychip
pushed a commit
that referenced
this pull request
Feb 5, 2024
Including for failures to write credentials and failure to rotate.
Monkeychip
pushed a commit
that referenced
this pull request
Feb 7, 2024
Including for failures to write credentials and failure to rotate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including for failures to write credentials and failure to rotate.