Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-22642: Include secret syncs in activity log responses #24710

Merged
merged 6 commits into from
Jan 15, 2024
Merged

VAULT-22642: Include secret syncs in activity log responses #24710

merged 6 commits into from
Jan 15, 2024

Conversation

miagilepner
Copy link
Contributor

Updating the documentation will be in a different PR.

@miagilepner miagilepner added this to the 1.15.5 milestone Jan 8, 2024
@miagilepner miagilepner requested a review from mpalmi January 8, 2024 17:54
@miagilepner miagilepner force-pushed the miagilepner/VAULT-22642-secret-sync-resp branch from 134d6c8 to 48be56c Compare January 8, 2024 17:54
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

CI Results:
All Go tests succeeded! ✅

@miagilepner miagilepner marked this pull request as ready for review January 9, 2024 09:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Build Results:
All builds succeeded! ✅

mpalmi
mpalmi approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. No major glaring issues that I could see, but I'll give it another pass tomorrow to be sure.

I did have a few questions around code organization, but none of the comments are super important.

vault/activity_log.go Outdated Show resolved Hide resolved
vault/activity_log.go Outdated Show resolved Hide resolved
vault/activity_log_util_common.go Show resolved Hide resolved
mpalmi
mpalmi approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good. Just added one last note about a godoc update for the new Add methods, but it's not a dealbreaker so still keeping this Approved.

vault/activity_log.go Show resolved Hide resolved
@miagilepner miagilepner merged commit caef593 into main Jan 15, 2024
110 checks passed
@miagilepner miagilepner deleted the miagilepner/VAULT-22642-secret-sync-resp branch January 15, 2024 10:40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpalmi mpalmi mpalmi approved these changes

Assignees

@mpalmi mpalmi

Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.15.5
Development

Successfully merging this pull request may close these issues.
2 participants
@miagilepner @mpalmi