Add permitPool support to S3 #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Mar 10, 2017
| @@ -55,6 +55,9 @@ cause Vault to attempt to retrieve credentials from the AWS metadata service. | |||
| - `session_token` `(string: "")` – Specifies the AWS session token. This can | |||
| also be provided via the environment variable `AWS_SESSION_TOKEN`. | |||
|
|
|||
| - `max_parallel` `(int: 128)` – Specifies The maximum number of concurrent | |||
| requests to S3. | |||
There was a problem hiding this comment.
It's actually a string :-/ All storage parameters are.
There was a problem hiding this comment.
Okay, easy enough to fix. Should I fix all the other ones that list it as an int as well? I copied this from the Azure docs, but Consul etc also list it as an int.
There was a problem hiding this comment.
If you don't mind, that would be fantastic :-)
vishalnayak
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 performance falls off after a certain number of connections so allow limiting it.