Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-22552: Add MaxConnsPerHost field to Agent template_config #24548

Merged
merged 11 commits into from
Jan 3, 2024

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Dec 14, 2023

This PR consumes the consul-template fix for issue hashicorp/consul-template#1840. The max_connections_per_host configuration parameter has been added to template_config which can be used to limit the total number of connections that Vault Agent Template can use for a particular Vault host. This limit
includes connections in the dialing, active, and idle states. A default of 10 will be used if the configuration parameter is not provided.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 14, 2023
Copy link

github-actions bot commented Dec 14, 2023

CI Results:
All Go tests succeeded! ✅

@ccapurso ccapurso marked this pull request as ready for review January 3, 2024 19:01
@ccapurso ccapurso requested a review from a team as a code owner January 3, 2024 19:01
@ccapurso ccapurso requested a review from VioletHynes January 3, 2024 19:02
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding the tests and docs updates. I've left a small wording comment that I'd like to see addressed, but otherwise LGTM!

Copy link

github-actions bot commented Jan 3, 2024

Build Results:
All builds succeeded! ✅

@ccapurso ccapurso merged commit 6b142b4 into main Jan 3, 2024
110 checks passed
@ccapurso ccapurso deleted the vault-22552-agent-template-config-max-conns branch January 3, 2024 20:06
Monkeychip pushed a commit that referenced this pull request Jan 7, 2024
* add MaxConnectionsPerHost to agent template config

* set MaxConnsPerHost in consul-template manager config

* add MaxConnectionsPerHost to agent generate-config

* fix agent generate-config tests

* doc updates

* bump consul-template to 0.36.0

* add changelog entry

* minor docs change

* fix nil pointer deref for MaxConnectionsPerHost template config

* Update template docs

Co-authored-by: Violet Hynes <[email protected]>

---------

Co-authored-by: Violet Hynes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants