-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-22552: Add MaxConnsPerHost field to Agent template_config #24548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Dec 14, 2023
CI Results: |
VioletHynes
reviewed
Jan 3, 2024
VioletHynes
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding the tests and docs updates. I've left a small wording comment that I'd like to see addressed, but otherwise LGTM!
Build Results: |
Co-authored-by: Violet Hynes <[email protected]>
Monkeychip
pushed a commit
that referenced
this pull request
Jan 7, 2024
* add MaxConnectionsPerHost to agent template config * set MaxConnsPerHost in consul-template manager config * add MaxConnectionsPerHost to agent generate-config * fix agent generate-config tests * doc updates * bump consul-template to 0.36.0 * add changelog entry * minor docs change * fix nil pointer deref for MaxConnectionsPerHost template config * Update template docs Co-authored-by: Violet Hynes <[email protected]> --------- Co-authored-by: Violet Hynes <[email protected]>
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consumes the
consul-template
fix for issue hashicorp/consul-template#1840. Themax_connections_per_host
configuration parameter has been added totemplate_config
which can be used to limit the total number of connections that Vault Agent Template can use for a particular Vault host. This limitincludes connections in the dialing, active, and idle states. A default of 10 will be used if the configuration parameter is not provided.