Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently refer to Key Value secrets engine as KV #24529

Merged
merged 9 commits into from
Dec 14, 2023

Conversation

hellobontempo
Copy link
Contributor

Historically we've been inconsistent across Vault products referring to the Key Value secrets engine. See one example in the docs below where there are three different styles of key value:
Screenshot 2023-12-13 at 2 20 44 PM

In a Vault UI sync meeting last week we discussed with design and the core PM to come to a consensus on how to refer to the Key Value secrets engine. We settled on Key Value as the complete term and KV version 1 (KV v1) or KV version 2 (KV v2), without the slash (K/V) because it's an acronym for the secrets engine. This PR updates references to K/V and Key/Value

@hellobontempo hellobontempo added this to the 1.16.0-rc1 milestone Dec 13, 2023
@hellobontempo hellobontempo requested a review from a team as a code owner December 13, 2023 22:24
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

CI Results:
Failures:

Test Type Package Test Logs
race vault TestOIDC_PeriodicFunc view test results
race vault TestOIDC_PeriodicFunc/test-key-nil-next-signing-key view test results

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consul docs also use KV instead of K/V, so I appreciate this change for better consistency. 👍

Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hellobontempo hellobontempo merged commit 2c19bbe into main Dec 14, 2023
109 of 110 checks passed
@hellobontempo hellobontempo deleted the ui/update-kv-v2-copy branch December 14, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants