-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently refer to Key Value secrets engine as KV #24529
Conversation
CI Results:
|
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consul docs also use KV
instead of K/V
, so I appreciate this change for better consistency. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically we've been inconsistent across Vault products referring to the Key Value secrets engine. See one example in the docs below where there are three different styles of key value:
In a Vault UI sync meeting last week we discussed with design and the core PM to come to a consensus on how to refer to the Key Value secrets engine. We settled on
Key Value
as the complete term andKV version 1
(KV v1
) orKV version 2
(KV v2
), without the slash (K/V
) because it's an acronym for the secrets engine. This PR updates references toK/V
andKey/Value