Vault 20270 docker test raft wal #24463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a migration test using snapshot restore
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results:
and 12 other tests |
|
Build Results: |
|
Removing vault-education-approvers from the PR as there don't seem to be any documentation updates. But feel free to re-add if need. |
raskchanky
reviewed
Jan 16, 2024
| // caching the old cluster's barrier keys | ||
| oldBarrierKeys := cluster.GetBarrierKeys() | ||
| // clean up the old cluster as there is no further use to it | ||
| cluster.Cleanup() |
There was a problem hiding this comment.
This call has already been deferred from the beginning of the function. This line means Cleanup() gets called twice on the original cluster. Is that problematic or no big deal?
There was a problem hiding this comment.
No it won't cause any issue. It just tries to clean up whatever is left, and if there is nothing left or even had been cleaned up before, it just moves on.
raskchanky
approved these changes
Jan 16, 2024
raskchanky
added a commit
that referenced
this pull request
Jan 25, 2024
* Implement raft-wal * go mod tidy * add metrics, fix a panic * fix the panic for real this time * PR feedback * refactor tests to use a helper and reduce duplication * add a test to verify we don't use raft-wal if raft.db exists * add config to enable the verifier * add tests for parsing verification intervals * run the verifier in the background * wire up the verifier * go mod tidy * refactor config parsing * remove unused function * trying to get the verifier working * wire up some more verifier bits * sorted out an error, added a new test, lots of debug logging that needs to come out * fix a bug and remove all the debugging statements * make sure we close raft-wal stablestore too * run verifier tests for both boltdb and raft-wal * PR feedback * Vault 20270 docker test raft wal (#24463) * adding a migration test from boltdb to raftwal and back adding a migration test using snapshot restore * feedback * Update physical/raft/raft.go Co-authored-by: Paul Banks <[email protected]> * PR feedback * change verifier function * make this shorter * add changelog * Fix Close behavior * make supporting empty logs more explicit * add some godocs --------- Co-authored-by: hamid ghaf <[email protected]> Co-authored-by: Hamid Ghaf <[email protected]> Co-authored-by: Paul Banks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://hashicorp.atlassian.net/browse/VAULT-20270
Adding tests to satisfy the following: