Backport of Fix two potential channel hangs in access.tryDecrypt into release/1.15.x #24422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/sgm/fix-potential-decrypt-hangs/nicely-great-haddock
branch
from
84ad238 to
4ff7275
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
sgmiller
approved these changes
Dec 7, 2023
|
Build Results: |
sgmiller
deleted the
backport/sgm/fix-potential-decrypt-hangs/nicely-great-haddock
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24418 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
The first could happen if an error is received and we call reportResult
synchronously. But there is no one listening on the other side until later
in the function. The second could occur if the context becomes done before
we receive the result. The goroutine would be stuck trying to report the
result to the chan which is still open, but the for { select } loop is no
longer checking resultCh.
Overview of commits