Add directory paths to KV capabilities checks #24404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
Monkeychip
changed the title
|
Build Results: |
zofskeez
reviewed
Dec 7, 2023
| @@ -95,9 +95,14 @@ export default class KvSecretMetadataModel extends Model { | |||
| }; | |||
| } | |||
|
|
|||
| get permissionsPath() { | |||
| return this.fullSecretPath || this.path; | |||
There was a problem hiding this comment.
Curious why fullSecretPath wouldn't always be the value to use if it represents the full path to the secret.
There was a problem hiding this comment.
Because it's generated by the serializer (not easy to see from the diff). And the payload does not always return data.keys. See here.
An example of when the serializer wouldn't return this.fullSecretPath is when we're looking at a secret's details.
zofskeez
approved these changes
Dec 7, 2023
Monkeychip
added a commit
that referenced
this pull request
Dec 7, 2023
* add getter to metadata model * add changelog and data model fix * add test coverage * add nested create coverage * Update 24404.txt * remove from data model * return to how it was
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #24130
Follow the instructions from the original issue to duplicate. The bug occurred because we were passing in
pathto the capabilities check butpathdoes not include the full path name.Ex: for secret
beep/bop/boopWe would always pass in
boopeven if we were searching for the list return ofbeep/bop/Now we pass in
beep/orbeep/bop/orbeep/bop/bopdepending on the path in the URL for the view.Screenshots using the policy on the issue
Before:
After:
